[SM6.10][Exec] Implement Remaining LinAlg Smoke Tests#8366
[SM6.10][Exec] Implement Remaining LinAlg Smoke Tests#8366V-FEXrt wants to merge 20 commits intomicrosoft:mainfrom
Conversation
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
V-FEXrt
changed the title
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
I haven't carefully reviewed every test, but overall shape etc. LGTM.
| [WaveSize(4, 64)] | ||
| [numthreads(NUMTHREADS, 1, 1)] | ||
| void main(uint threadID : SV_GroupIndex) { | ||
| if (WaveReadLaneFirst(threadID) != 0) |
There was a problem hiding this comment.
I don't think this test approach works. These linalg calls (and most being tested) should normally be active/uniform across all threads in a wave (for wave/thread scope) or all threads in a group (for threadgroup scope). This if prevents all but the first thread from being active.
This will complicate the testing approach, but it's still doable. For instance, you can use the new GetGroupWaveIndex() and GetGroupWaveCount() to do per-wave inputs/outputs for thread/wave scope. For group scope, all lanes should simply be active, and everything occurs at group scope.
There was a problem hiding this comment.
This wave op produces a wave-uniform value, so this makes all but one wave exit.
There was a problem hiding this comment.
Sorry I misread, but still we could use GetGroupWaveIndex() for this purpose, and we should only do so when not group scope.
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
4 participants
Implements the remaining smoke tests for the LinAlg DXIL ops
Fixes #8126
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com